improvement(kb): add document filtering, select all, and React Query migration #2951

waleedlatif1 · 2026-01-23T02:30:53Z

Summary

Add document filter dropdown (All/Enabled/Disabled)
Add "Select all" for bulk operations across all documents
Migrate tag definitions hooks to React Query
Consolidate formatting utilities (formatRelativeTime, formatAbsoluteDate, formatDuration)
Add token hover indicator in chunk editor
Disable save buttons when no changes made
Clean up dead code and unnecessary re-exports

Type of Change

Improvement (non-breaking enhancement)

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…migration

vercel · 2026-01-23T02:30:58Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 23, 2026 3:21am

greptile-apps · 2026-01-23T02:34:19Z

Greptile Summary

Adds document filtering dropdown (All/Enabled/Disabled) and select-all functionality for bulk operations across all documents in knowledge base management
Migrates tag definitions hooks to React Query for improved caching and state management, replacing manual fetch logic with centralized query patterns
Consolidates formatting utilities (formatRelativeTime, formatAbsoluteDate, formatDuration) into /lib/core/utils/formatting to eliminate code duplication across components

Important Files Changed

Filename	Overview
`apps/sim/lib/knowledge/documents/service.ts`	Refactored to support new filtering with `enabledFilter` parameter and added `bulkDocumentOperationByFilter` for select-all operations
`apps/sim/app/api/knowledge/[id]/documents/route.ts`	Enhanced API endpoint with flexible filtering, select-all bulk operations, and updated schema validation for new functionality
`apps/sim/hooks/queries/knowledge.ts`	Added comprehensive React Query hooks for tag definitions with proper caching, invalidation, and error handling patterns
`apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx`	Implemented document filtering UI, select-all mode state management, and migrated to centralized formatting utilities
`apps/sim/lib/core/utils/formatting.ts`	Consolidated formatting utilities from multiple components with enhanced functionality and consistent interfaces

Confidence score: 4/5

This PR requires careful review due to complex state management changes and API modifications that could affect bulk operations
Score reflects well-structured React Query migration and proper consolidation of utilities, but lowered due to complex filtering logic and potential edge cases in select-all functionality
Pay close attention to bulk operation files and the new filtering logic in the service layer to ensure proper handling of edge cases

Sequence Diagram

sequenceDiagram
    participant User
    participant API as "GET /api/knowledge/[id]/documents"
    participant Auth as "getSession"
    participant Access as "checkKnowledgeBaseAccess"
    participant Service as "getDocuments"
    participant DB as "Database"

    User->>API: "GET with enabledFilter param"
    API->>Auth: "getSession()"
    Auth-->>API: "session"
    
    alt session invalid
        API-->>User: "401 Unauthorized"
    else session valid
        API->>Access: "checkKnowledgeBaseAccess(id, userId)"
        Access->>DB: "verify access"
        DB-->>Access: "access result"
        
        alt no access
            Access-->>API: "hasAccess: false"
            API-->>User: "401/404 error"
        else has access
            Access-->>API: "hasAccess: true, knowledgeBase"
            API->>Service: "getDocuments(id, filters, requestId)"
            Service->>DB: "query with enabledFilter"
            DB-->>Service: "documents + pagination"
            Service-->>API: "documents data"
            API-->>User: "200 success with filtered documents"
        end
    end

waleedlatif1 · 2026-01-23T02:38:51Z

@greptile

greptile-apps

_{26 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/app/api/knowledge/[id]/documents/route.ts

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-23T03:30:42Z

apps/sim/hooks/kb/use-knowledge.ts

-    async (newPage: number) => {
-      if (newPage < 1 || newPage > totalPages) return
+    (newPage: number): boolean => {
+      return newPage >= 1 && newPage <= totalPages


goToPage function no longer performs navigation

High Severity

The goToPage function in useDocumentChunks was changed from an async function that performs navigation to a synchronous function that only validates page numbers. However, the consuming code still calls await initialGoToPage(page) expecting it to perform navigation. This breaks chunk pagination functionality entirely.

Additional Locations (1)

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx#L339-L340

cursor · 2026-01-23T03:30:42Z

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx

                    {renderSortableHeader('chunkCount', 'Chunks', 'w-[8%]')}
                    {renderSortableHeader('uploadedAt', 'Uploaded', 'w-[11%]')}
-                    {renderSortableHeader('processingStatus', 'Status', 'w-[10%]')}
+                    {renderSortableHeader('enabled', 'Status', 'w-[10%]')}


Status column sorts by enabled instead of processing status

Medium Severity

The Status column header sorts by enabled field but displays processing status badges (Pending, Processing, Failed, Enabled/Disabled). This creates a mismatch where clicking the Status column header sorts by enabled/disabled boolean instead of the displayed processing status, producing unexpected and confusing sort results.

Additional Locations (1)

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx#L1267-L1280

cursor · 2026-01-23T03:30:42Z

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx

      setSelectedDocuments(new Set(documents.map((doc) => doc.id)))
    } else {
      setSelectedDocuments(new Set())
+      setIsSelectAllMode(false)


Select-all mode not cleared when deselecting documents

High Severity

When in select-all mode (selecting all documents across all pages), manually deselecting an individual document via checkbox doesn't clear isSelectAllMode. This causes bulk operations to still affect all documents, including ones the user explicitly deselected, leading to data loss or unintended modifications.

…2973) * fix(subflows): tag dropdown + resolution logic (#2949) * fix(subflows): tag dropdown + resolution logic * fixes; * revert parallel change * chore(deps): bump posthog-js to 1.334.1 (#2948) * fix(idempotency): add conflict target to atomicallyClaimDb query + remove redundant db namespace tracking (#2950) * fix(idempotency): add conflict target to atomicallyClaimDb query * delete needs to account for namespace * simplify namespace filtering logic * fix cleanup * consistent target * improvement(kb): add document filtering, select all, and React Query migration (#2951) * improvement(kb): add document filtering, select all, and React Query migration * test(kb): update tests for enabledFilter and removed userId params * fix(kb): remove non-null assertion, add explicit guard * improvement(logs): trace span, details (#2952) * improvement(action-bar): ordering * improvement(logs): details, trace span * feat(blog): v0.5 release post (#2953) * feat(blog): v0.5 post * improvement(blog): simplify title and remove code block header - Simplified blog title from "Introducing Sim Studio v0.5" to "Introducing Sim v0.5" - Removed language label header and copy button from code blocks for cleaner appearance Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ack PR comments * small styling improvements * created system to create post-specific components * updated componnet * cache invalidation --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat(admin): add credits endpoint to issue credits to users (#2954) * feat(admin): add credits endpoint to issue credits to users * fix(admin): use existing credit functions and handle enterprise seats * fix(admin): reject NaN and Infinity in amount validation * styling * fix(admin): validate userId and email are strings * improvement(copilot): fast mode, subagent tool responses and allow preferences (#2955) * Improvements * Fix actions mapping * Remove console logs * fix(billing): handle missing userStats and prevent crashes (#2956) * fix(billing): handle missing userStats and prevent crashes * fix(billing): correct import path for getFilledPillColor * fix(billing): add Number.isFinite check to lastPeriodCost * fix(logs): refresh logic to refresh logs details (#2958) * fix(security): add authentication and input validation to API routes (#2959) * fix(security): add authentication and input validation to API routes * moved utils * remove extraneous commetns * removed unused dep * improvement(helm): add internal ingress support and same-host path consolidation (#2960) * improvement(helm): add internal ingress support and same-host path consolidation * improvement(helm): clean up ingress template comments Simplify verbose inline Helm comments and section dividers to match the minimal style used in services.yaml. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(helm): add missing copilot path consolidation for realtime host When copilot.host equals realtime.host but differs from app.host, copilot paths were not being routed. Added logic to consolidate copilot paths into the realtime rule for this scenario. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * improvement(helm): follow ingress best practices - Remove orphan comments that appeared when services were disabled - Add documentation about path ordering requirements - Paths rendered in order: realtime, copilot, app (specific before catch-all) - Clean template output matching industry Helm chart standards --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat(blog): enterprise post (#2961) * feat(blog): enterprise post * added more images, styling * more content * updated v0-5 post * remove unused transition --------- Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> * fix(envvars): resolution standardized (#2957) * fix(envvars): resolution standardized * remove comments * address bugbot * fix highlighting for env vars * remove comments * address greptile * address bugbot * fix(copilot): mask credentials fix (#2963) * Fix copilot masking * Clean up * Lint * improvement(webhooks): remove dead code (#2965) * fix(webhooks): subscription recreation path * improvement(webhooks): remove dead code * fix tests * address bugbot comments * fix restoration edge case * fix more edge cases * address bugbot comments * fix gmail polling * add warnings for UI indication for credential sets * fix(preview): subblock values (#2969) * fix(child-workflow): nested spans handoff (#2966) * fix(child-workflow): nested spans handoff * remove overly defensive programming * update type check * type more code * remove more dead code * address bugbot comments * fix(security): restrict API key access on internal-only routes (#2964) * fix(security): restrict API key access on internal-only routes * test(security): update function execute tests for checkInternalAuth * updated agent handler * move session check higher in checkSessionOrInternalAuth * extracted duplicate code into helper for resolving user from jwt * fix(copilot): update copilot chat title (#2968) * fix(hitl): fix condition blocks after hitl (#2967) * fix(notes): ghost edges (#2970) * fix(notes): ghost edges * fix deployed state fallback * fallback * remove UI level checks * annotation missing from autoconnect source check * improvement(docs): loop and parallel var reference syntax (#2975) * fix(blog): slash actions description (#2976) * improvement(docs): loop and parallel var reference syntax * fix(blog): slash actions description * fix(auth): copilot routes (#2977) * Fix copilot auth * Fix * Fix * Fix * fix(copilot): fix edit summary for loops/parallels (#2978) * fix(integrations): hide from tool bar (#2544) * fix(landing): ui (#2979) * fix(edge-validation): race condition on collaborative add (#2980) * fix(variables): boolean type support and input improvements (#2981) * fix(variables): boolean type support and input improvements * fix formatting --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

…2973) * fix(subflows): tag dropdown + resolution logic (#2949) * fix(subflows): tag dropdown + resolution logic * fixes; * revert parallel change * chore(deps): bump posthog-js to 1.334.1 (#2948) * fix(idempotency): add conflict target to atomicallyClaimDb query + remove redundant db namespace tracking (#2950) * fix(idempotency): add conflict target to atomicallyClaimDb query * delete needs to account for namespace * simplify namespace filtering logic * fix cleanup * consistent target * improvement(kb): add document filtering, select all, and React Query migration (#2951) * improvement(kb): add document filtering, select all, and React Query migration * test(kb): update tests for enabledFilter and removed userId params * fix(kb): remove non-null assertion, add explicit guard * improvement(logs): trace span, details (#2952) * improvement(action-bar): ordering * improvement(logs): details, trace span * feat(blog): v0.5 release post (#2953) * feat(blog): v0.5 post * improvement(blog): simplify title and remove code block header - Simplified blog title from Introducing Sim Studio v0.5 to Introducing Sim v0.5 - Removed language label header and copy button from code blocks for cleaner appearance Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ack PR comments * small styling improvements * created system to create post-specific components * updated componnet * cache invalidation --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat(admin): add credits endpoint to issue credits to users (#2954) * feat(admin): add credits endpoint to issue credits to users * fix(admin): use existing credit functions and handle enterprise seats * fix(admin): reject NaN and Infinity in amount validation * styling * fix(admin): validate userId and email are strings * improvement(copilot): fast mode, subagent tool responses and allow preferences (#2955) * Improvements * Fix actions mapping * Remove console logs * fix(billing): handle missing userStats and prevent crashes (#2956) * fix(billing): handle missing userStats and prevent crashes * fix(billing): correct import path for getFilledPillColor * fix(billing): add Number.isFinite check to lastPeriodCost * fix(logs): refresh logic to refresh logs details (#2958) * fix(security): add authentication and input validation to API routes (#2959) * fix(security): add authentication and input validation to API routes * moved utils * remove extraneous commetns * removed unused dep * improvement(helm): add internal ingress support and same-host path consolidation (#2960) * improvement(helm): add internal ingress support and same-host path consolidation * improvement(helm): clean up ingress template comments Simplify verbose inline Helm comments and section dividers to match the minimal style used in services.yaml. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(helm): add missing copilot path consolidation for realtime host When copilot.host equals realtime.host but differs from app.host, copilot paths were not being routed. Added logic to consolidate copilot paths into the realtime rule for this scenario. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * improvement(helm): follow ingress best practices - Remove orphan comments that appeared when services were disabled - Add documentation about path ordering requirements - Paths rendered in order: realtime, copilot, app (specific before catch-all) - Clean template output matching industry Helm chart standards --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * feat(blog): enterprise post (#2961) * feat(blog): enterprise post * added more images, styling * more content * updated v0-5 post * remove unused transition --------- Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> * fix(envvars): resolution standardized (#2957) * fix(envvars): resolution standardized * remove comments * address bugbot * fix highlighting for env vars * remove comments * address greptile * address bugbot * fix(copilot): mask credentials fix (#2963) * Fix copilot masking * Clean up * Lint * improvement(webhooks): remove dead code (#2965) * fix(webhooks): subscription recreation path * improvement(webhooks): remove dead code * fix tests * address bugbot comments * fix restoration edge case * fix more edge cases * address bugbot comments * fix gmail polling * add warnings for UI indication for credential sets * fix(preview): subblock values (#2969) * fix(child-workflow): nested spans handoff (#2966) * fix(child-workflow): nested spans handoff * remove overly defensive programming * update type check * type more code * remove more dead code * address bugbot comments * fix(security): restrict API key access on internal-only routes (#2964) * fix(security): restrict API key access on internal-only routes * test(security): update function execute tests for checkInternalAuth * updated agent handler * move session check higher in checkSessionOrInternalAuth * extracted duplicate code into helper for resolving user from jwt * fix(copilot): update copilot chat title (#2968) * fix(hitl): fix condition blocks after hitl (#2967) * fix(notes): ghost edges (#2970) * fix(notes): ghost edges * fix deployed state fallback * fallback * remove UI level checks * annotation missing from autoconnect source check * improvement(docs): loop and parallel var reference syntax (#2975) * fix(blog): slash actions description (#2976) * improvement(docs): loop and parallel var reference syntax * fix(blog): slash actions description * fix(auth): copilot routes (#2977) * Fix copilot auth * Fix * Fix * Fix * fix(copilot): fix edit summary for loops/parallels (#2978) * fix(integrations): hide from tool bar (#2544) * fix(landing): ui (#2979) * fix(edge-validation): race condition on collaborative add (#2980) * fix(variables): boolean type support and input improvements (#2981) * fix(variables): boolean type support and input improvements * fix formatting --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Siddharth Ganesan <33737564+Sg312@users.noreply.github.com> Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

improvement(kb): add document filtering, select all, and React Query …

3aedf41

…migration

test(kb): update tests for enabledFilter and removed userId params

1388822

vercel bot temporarily deployed to Preview January 23, 2026 02:38 Inactive

This comment was marked as outdated.

Sign in to view

greptile-apps bot reviewed Jan 23, 2026

View reviewed changes

apps/sim/app/api/knowledge/[id]/documents/route.ts Outdated Show resolved Hide resolved

fix(kb): remove non-null assertion, add explicit guard

9009a29

vercel bot temporarily deployed to Preview January 23, 2026 03:21 Inactive

waleedlatif1 merged commit 7f22628 into staging Jan 23, 2026
7 checks passed

waleedlatif1 deleted the improvement/kb branch January 23, 2026 03:25

cursor bot reviewed Jan 23, 2026

View reviewed changes

waleedlatif1 mentioned this pull request Jan 24, 2026

v0.5.69: kb upgrades, blog, copilot improvements, auth consolidation #2973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improvement(kb): add document filtering, select all, and React Query migration #2951

improvement(kb): add document filtering, select all, and React Query migration #2951

Uh oh!

waleedlatif1 commented Jan 23, 2026

Uh oh!

vercel bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

waleedlatif1 commented Jan 23, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Jan 23, 2026

Uh oh!

cursor bot Jan 23, 2026

Uh oh!

cursor bot Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

improvement(kb): add document filtering, select all, and React Query migration #2951

improvement(kb): add document filtering, select all, and React Query migration #2951

Uh oh!

Conversation

waleedlatif1 commented Jan 23, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Important Files Changed

Confidence score: 4/5

Sequence Diagram

Uh oh!

waleedlatif1 commented Jan 23, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 23, 2026

Choose a reason for hiding this comment

goToPage function no longer performs navigation

Uh oh!

cursor bot Jan 23, 2026

Choose a reason for hiding this comment

Status column sorts by enabled instead of processing status

Uh oh!

cursor bot Jan 23, 2026

Choose a reason for hiding this comment

Select-all mode not cleared when deselecting documents

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 23, 2026 •

edited

Loading

greptile-apps bot commented Jan 23, 2026 •

edited

Loading